Skip to content

Fix incorrect unicode escape sequence encodings #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

kperryua
Copy link
Contributor

@kperryua kperryua commented Nov 6, 2024

We had a testing gap in the encoding of strings containing low unicode escape sequences. The recent JSONWriter re-write broke these, and the missing test means we didn't catch it.

Single digit hex values were getting / 16 when % 16 was more correct (though actually unnecessary).
Double digit hex values were in reverse order.

@kperryua
Copy link
Contributor Author

kperryua commented Nov 6, 2024

@swift-ci Please test

@kperryua kperryua requested a review from jmschonfeld November 6, 2024 00:04
@kperryua kperryua merged commit 79bd7e5 into swiftlang:main Nov 6, 2024
3 checks passed
cthielen pushed a commit to cthielen/swift-foundation that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants